This repository was archived by the owner on Mar 17, 2026. It is now read-only.
Closed
Conversation
thodges-gh
requested review from
a team,
andrejrakic,
pappas999 and
zeuslawyer
as code owners
zeuslawyer
approved these changes
Aug 21, 2025
Contributor
There was a problem hiding this comment.
LGTM - as per comments re CI/CD update without bumping/releasing to NPM. And also investigating hard pin versions as ccip-js package was correctly building some weeks ago for the last release of the package (v0.2.5 on July 1).
Also feel free to just put me as reviewer -unless the codeowners automatically adds all of DevRel.
Contributor
Author
|
Yeah codeowners automatically threw everyone up there. |
Contributor
Author
|
Better fix here: #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing and building was broken due to ESM compatibility with chai@5 (pure ESM) and Hardhat. Pinning chai to V4 resolves the ESM incompatibility with Hardhat's chai matchers. Also removes unnecessary requires in Hardhat config. Build is now successful.